update datasource connection when manually introspecting #6968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Breaking changes detected in the OpenAPI specification! |
Light2Dark
force-pushed
the
sham/update-datasource-connections-based-on-introspection
branch
from
f9bac28 to
5724bdc
Compare
|
Breaking changes detected in the OpenAPI specification! |
Contributor
Author
|
not sure why the spec is failing. |
|
Breaking changes detected in the OpenAPI specification! |
mscolnick
previously approved these changes
Oct 29, 2025
Light2Dark
force-pushed
the
sham/update-datasource-connections-based-on-introspection
branch
from
c906ae6 to
999dc1c
Compare
|
Breaking changes detected in the OpenAPI specification! |
mscolnick
previously approved these changes
Oct 29, 2025
Light2Dark
force-pushed
the
sham/update-datasource-connections-based-on-introspection
branch
from
999dc1c to
9ecf1ed
Compare
|
Breaking changes detected in the OpenAPI specification! |
Light2Dark
force-pushed
the
sham/update-datasource-connections-based-on-introspection
branch
from
9ecf1ed to
482ae68
Compare
|
Breaking changes detected in the OpenAPI specification! |
Light2Dark
force-pushed
the
sham/update-datasource-connections-based-on-introspection
branch
from
482ae68 to
51e6b24
Compare
|
Breaking changes detected in the OpenAPI specification! |
mscolnick
approved these changes
Nov 4, 2025
mscolnick
reviewed
Nov 4, 2025
Contributor
mscolnick
left a comment
mscolnick
left a comment
There was a problem hiding this comment.
just FYI, this perf is not bad (as you said its m + n), but it could be O(1) if we do find it becomes an issue
Light2Dark
deleted the
sham/update-datasource-connections-based-on-introspection
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Upon introspecting the database on the left-hand panel, we receive the messages and update the datasource connection, therefore ensuring autocompletions and context are loaded for AI or editing.
Added perf tests to see the impact, and it was very fast due to how db's are hierarchied. O(m+n+p), m < n < p.
Avg time is 0.0033ms on large hierarchy
🔍 Description of Changes
📋 Checklist